My first attempt at creating a network diagram

Hi r/networking,

Beginner here; very new to networking. This is my first attempt at building a network diagram (well, at least of this sort of complexity). I used draw.io to make this diagram (also my first time using this software).

I would appreciate any feedback on this diagram -- particularly at whether I have all the IP addresses mapped out properly.

IP Addresses given by Internet Provider:

• Internet access:

o 210.35.24.32 /30 bits (Site1 - left side) Gateway 210.35.24.1

o 200.23.32.100 / 32 bits (Site2 - right side) Gateway 200.23.32.1

• Remote Access:

o 210.35.24.100 (Site1 - left side) Gateway 210.35.24.1

o 200.23.32.105 / 32 bits (Site2 - right side) Gateway 200.23.32.1

​

Other things that I am unsure of:
-Does the UPS make sense being connected to S1 for site 1 and S10 for site 2?

I don't know what I don't know. For example:

Originally, I had the SAN (connected to S1) and then the file servers and email servers connected to the SAN. But feedback from someone suggested that the email server and the file servers are to be connected to S1 and then connect the SAN to those servers. Additionally, the SAN only has two connections, and as such, a switch can be used to solve this. It is stuff like this that I had no idea of.

Diagram: https://i.imgur.com/b9vQOgs.png

​

If you would like to access the draw.io file, let me know.

Thanks in advance.