I'm configuring a BGP connection with an ISP, never done it before (static routing only previously).

Does anyone have any (Junos Preferably) configuration examples they can share of this?

Our ASN is private (64512-65534).

What i have so far is:

set routing-options router-id <our-ext-ip>

set routing-options autonomous-system <private asn>

set protocols bgp group isp type external peer-as <isp asn> neighbor <isp router>

I've also allowed bgp traffic in via host-inbound-traffic on the external interface.

The standard source nat rules are in place to provide trust zone clients with internet.

The connections are still being provisioned but i thought I'd ask if I'm missing anything obvious?